Skip to content

🐛 Handle nil when parsing fragment #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 9, 2025
Merged

🐛 Handle nil when parsing fragment #268

merged 11 commits into from
Jul 9, 2025
+42 −2

Conversation

pboling
Copy link
Contributor

@pboling pboling commented Jul 8, 2025 •
edited
Loading

Fixes #267

  • Red/Green - added failing test, then fixed

kou
kou reviewed Jul 9, 2025
View reviewed changes
pboling and others added 3 commits July 9, 2025 07:47
pboling
pboling commented Jul 9, 2025
View reviewed changes
kou
kou reviewed Jul 9, 2025
View reviewed changes
kou
kou reviewed Jul 9, 2025
View reviewed changes
@kou kou merged commit 04a589a into ruby:master Jul 9, 2025
67 checks passed
@kou
Copy link
Member

kou commented Jul 9, 2025

Thanks.

@pboling pboling deleted the bug/267-xpath-parser-handle-nil branch July 9, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XPathParser#parse should work when node.document is nil
2 participants
@pboling @kou