RFC9586 UIDONLY support #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is accomplished by making UIDFetchData subclass FetchData. I instinctively prefer to extact a module or a shared superclass and put all of the accessor methods on that. I did it this way in order to preserve the attribute accessor rdoc on FetchData. But it feels wrong to me that UIDFetchData is subclassing FetchData: * It's a small violation of Liskov's Substitution Principle, for #seqno (and, to a lesser extent, #uid). * Any case statements or pattern matching that are looking for FetchData will also match UIDFetchData, which may not be correct. It also complicates matching only UIDFetchData, because you need to ensure that when/in UIDFetchData comes before any when/in FetchData. On the other hand, it's probably a good thing that FetchData#=== matches UIDFetchData too. Other than #seqno (which is prohibited by `UIDONLY`) any code that works for FetchData today should work with UIDFetchData.
nevans
force-pushed
the
RFC9586-UIDONLY
branch
2 times, most recently
from
dcbef82 to
57ac8b4
Compare
This way, we can get the correct Struct field names for both classes, without needing to undef, alias, etc. It also fixes Struct methods like `to_h` and `deconstruct_keys`.
This reduces duplication between `fetch_internal` and `store_internal`.
nevans
force-pushed
the
RFC9586-UIDONLY
branch
from
57ac8b4 to
7761764
Compare
nevans
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKA "UI donly", apparently.