Fix: generate_json_float to reserve enough memory for large negative floats. #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
force-pushed
the
reported-segv
branch
2 times, most recently
from
3b2d273 to
64bd3e2
Compare
byroot
added a commit
to byroot/json
that referenced
this pull request
May 23, 2025
This would have caught ruby#808 on CI.
byroot
added a commit
to byroot/json
that referenced
this pull request
May 23, 2025
This would have caught ruby#808 on CI.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 26, 2025
This would have caught ruby/json#808 on CI. ruby/json@8109421fb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #807
Since #800,
fpconv_dtoacan actually generate up to 28 chars.