Skip to content

Conversation

aslakhellesoy
Copy link

This is a fix for #408

I wasn't sure where to update the documentation - please let me know if you require more changes.

@film42
Copy link
Member

film42 commented Jan 7, 2020

Thanks for this PR! Don't worry about the 1.9.3 failure. We should probably drop 1.9.3 support.

@film42 film42 merged commit a84b39f into ruby-protobuf:3-10-stable Jan 7, 2020
@aslakhellesoy
Copy link
Author

Thanks for merging so quickly! I see you released 3.10.3, but CHANGES.md doesn't reflect it.

@aslakhellesoy aslakhellesoy deleted the lower-camel-case-field-names-json branch January 7, 2020 15:39
@film42
Copy link
Member

film42 commented Jan 7, 2020

Thanks for the reminder! Totally spaced. I'll update CHANGES once I merge my PR that updates travis and gets CI passing again.

@aslakhellesoy
Copy link
Author

I also believe you need to create a new 3-11-stable maintenance branch now eh? :-) Life as an open source contributor...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants