Add POM Refactor #160
Open
Add POM Refactor #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvitazwar
commented
Aug 21, 2023
alvitazwar
commented
- Added Assertions
- Implemented POM structure
- Enhanced Test execution time
- Reduce Test Flakiness
|
Code coverage report: https://gh-reports.rt.gw/login-with-google/refs/pull/160/merge/ |
| expect(this.page.locator(selectors.validateOption)).not.toBe(null); | ||
| } | ||
| // this function is used to add Login with google block after validate Block | ||
| async addLoginGoogleBlock(){ |
Contributor
There was a problem hiding this comment.
@alvitazwar
Add the assertions for this function. Validate whether the block is added successfully.
| buttonSaveSetting: "role=button[name='Save Changes'i]", | ||
| messageSaveSetting: "#setting-error-settings_updated", | ||
| clientIdInput: '#client-id', | ||
| clientIdValue: '278082871881-qp9srgor0iqvl1aq200ctf1sdb49bli1.apps.googleusercontent.com', |
Contributor
There was a problem hiding this comment.
@alvitazwar Add this client ID and secret in .env or repo secret. This should not be publicly visible.
Contributor
pooja-muchandikar
left a comment
pooja-muchandikar
left a comment
There was a problem hiding this comment.
@alvitazwar In specs/09_logout-login-button.js - Why this test case has been removed? This test should be present in order to validate login functionality.
Along with POM implementation, need to update the playwright package version as well. Do update the playwright version in package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.