Feat: Add phpcs fixes and Update composer.json and vendor files #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbhalodia
commented
Feb 14, 2023
hbhalodia
commented
- Add PHPCS fixes.
- Updated composer.json files and vendor changes
- [do-not-scan]
* Fix: phpcs errors 1. Blank line after function. 2. Ignore WordPress.NamingConventions.ValidHookName.UseUnderscores because of backward compatibility * Fix: phpcs error for equal sign alignment * Fix: phpcs errors 1. Spacing and equal line alignement issue. 2. Ignore object param and return type because assuming php greater than 7.1 also requrires php 7.4 as plugin description. 3. Change CamelCase to snake_case variables. * Fix: phpcs error for file /tests/bootstrap.php for spacing issue * Fix: phpcs errors 1. Spacing and alignment issue. 2. Naming convention 3. Multiline array comma issue * Fix issue added by bot for undefined variable * Exclude hook name validation rule instead ignoring * Update unit tests workflow * Add slah before wp_json_encode function * Revert json encode change
thelovekesh
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.