Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2024

For reasons I admit I do not understand, the deprecation warnings for StaticSingleThreadedExecutor on Windows happen when we construct a shared_ptr for it in the tests. If we construct a regular object, then it is fine. Luckily this test does not require a shared_ptr, so just make it a regular object here, which fixes the warning.

While we are in here, make all of the tests camel case to be consistent.

This should fix the warnings introduced by #2683 . @jmachowinski @fujitatomoya FYI


This is an automatic backport of pull request #2692 done by Mergify.

For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit 3310f9e)

# Conflicts:
#	rclcpp/test/rclcpp/executors/test_executors.cpp
@mergify mergify bot added the conflicts label Dec 3, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Dec 3, 2024

Cherry-pick of 3310f9e has failed:

On branch mergify/bp/jazzy/pr-2692
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 3310f9ea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/executors/test_executors.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 3, 2024
Signed-off-by: Tomoya Fujita <[email protected]>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 3, 2024

Pulls: #2694
Gist: https://gist.githubusercontent.com/fujitatomoya/b421bc8de31710efb855f13ee721174d/raw/563ee7b67742e0d34851f03293c1e400ce11646b/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14904

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e217532 into jazzy Dec 4, 2024
2 of 3 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-2692 branch December 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants