-
Notifications
You must be signed in to change notification settings - Fork 478
Add option for the events executor to the isolated component container #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,8 @@ | |
| // limitations under the License. | ||
|
|
||
| #include <memory> | ||
| #include <vector> | ||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "rclcpp/executors/single_threaded_executor.hpp" | ||
| #include "rclcpp/executors/multi_threaded_executor.hpp" | ||
|
|
@@ -24,28 +24,50 @@ | |
|
|
||
| int main(int argc, char * argv[]) | ||
| { | ||
| /// Component container with dedicated single-threaded executors for each components. | ||
| /// Component container with dedicated executor for each component | ||
| rclcpp::init(argc, argv); | ||
|
|
||
| // parse arguments | ||
| bool use_multi_threaded_executor{false}; | ||
| // valid entries: --executor-type single-threaded, --executor-type multi-threaded, --executor-type events | ||
| std::vector<std::string> args = rclcpp::remove_ros_arguments(argc, argv); | ||
| for (auto & arg : args) { | ||
| if (arg == std::string("--use_multi_threaded_executor")) { | ||
| use_multi_threaded_executor = true; | ||
| rclcpp::Node::SharedPtr node; | ||
|
|
||
| std::string executor_type = "single-threaded"; // default | ||
| for (size_t i = 0; i < args.size(); ++i) { | ||
| if (args[i] == "--executor-type") { | ||
| if (i + 1 < args.size()) { | ||
| executor_type = args[i + 1]; | ||
| break; | ||
| } | ||
| } else if (args[i] == "--use_multi_threaded_executor") { // backward compatibility | ||
| RCLCPP_WARN(node->get_logger(), | ||
| "--use_multi_threaded_executor is deprecated, use --executor-type multi-threaded instead."); | ||
| executor_type = "multi-threaded"; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it would be probably nice to add message for user, that this option is deprecated? |
||
| } | ||
| } | ||
|
|
||
| // create executor and component manager | ||
| auto exec = std::make_shared<rclcpp::executors::SingleThreadedExecutor>(); | ||
| rclcpp::Node::SharedPtr node; | ||
| if (use_multi_threaded_executor) { | ||
| using ComponentManagerIsolated = | ||
| rclcpp_components::ComponentManagerIsolated<rclcpp::executors::MultiThreadedExecutor>; | ||
| std::shared_ptr<rclcpp::Executor> exec; | ||
| if (executor_type == "events") { | ||
| using executor = rclcpp::experimental::executors::EventsExecutor; | ||
| using ComponentManagerIsolated = rclcpp_components::ComponentManagerIsolated<executor>; | ||
| exec = std::make_shared<executor>(); | ||
| node = std::make_shared<ComponentManagerIsolated>(exec); | ||
| } else { | ||
| using ComponentManagerIsolated = | ||
| rclcpp_components::ComponentManagerIsolated<rclcpp::executors::SingleThreadedExecutor>; | ||
| } else if (executor_type == "multi-threaded") { | ||
| using executor = rclcpp::executors::MultiThreadedExecutor; | ||
| using ComponentManagerIsolated = rclcpp_components::ComponentManagerIsolated<executor>; | ||
| exec = std::make_shared<executor>(); | ||
| node = std::make_shared<ComponentManagerIsolated>(exec); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is also behavior change compared to before. before, it creates There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was the old code: if (use_multi_threaded_executor) {
using ComponentManagerIsolated =
rclcpp_components::ComponentManagerIsolated<rclcpp::executors::MultiThreadedExecutor>;So I do not recognise this:
Can you elaborate? |
||
| } else if (executor_type == "single-threaded") { | ||
| using executor = rclcpp::executors::SingleThreadedExecutor; | ||
| using ComponentManagerIsolated = rclcpp_components::ComponentManagerIsolated<executor>; | ||
| exec = std::make_shared<executor>(); | ||
| node = std::make_shared<ComponentManagerIsolated>(exec); | ||
| } else { | ||
| std::cerr << "Invalid executor type: " << executor_type << std::endl; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is actually behavior change compared to before. before, even if user specify the wrong option, that falls back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Same as before, if nothing is supplied the Only if previously the user supplied a non-existent option with a non-existent executor this is a behavior change: But that would be a great coincidence I guess. As the |
||
| return 1; | ||
| } | ||
|
|
||
| exec->add_node(node); | ||
| exec->spin(); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.