Move event callback binding to PublisherBase and SubscriptionBase #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
Contributor
Author
|
methylDragon
requested review from
hidmic,
ivanpauno and
wjwwood
as code owners
Contributor
Author
|
Rpr is happy, so I'm happy 😬 |
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
for code maintenance this duplication should be avoided, lgtm with minor comment.
Collaborator
|
@ivanpauno @hidmic either of you can review on this? |
alsora
reviewed
Dec 16, 2022
alsora
approved these changes
Dec 16, 2022
ivanpauno
requested changes
Dec 16, 2022
Signed-off-by: methylDragon <[email protected]>
Contributor
Author
|
One more run of CI
|
delete-merged-branch
bot
deleted the
ch3/bind-subscription-callbacks-in-base
branch
sloretz
added a commit
to sloretz/drake-ros
that referenced
this pull request
Jan 11, 2023
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
sloretz
added a commit
to sloretz/drake-ros
that referenced
this pull request
Feb 1, 2023
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
sloretz
added a commit
to sloretz/drake-ros
that referenced
this pull request
Feb 1, 2023
APIs we're using changed in ros2/rclcpp#2066 which is released in RCLCPP 18.0.0 in ROS ROlling. This PR uses the updated API.
EricCousineau-TRI
added a commit
to RobotLocomotion/drake-ros
that referenced
this pull request
Feb 16, 2023
The APIs we're using changed in ros2/rclcpp#2066, which is released in rclcpp 18.0.0 in ROS 2 rolling Additionally works around ros2/rosbag2#1242 Co-authored-by: Eric Cousineau <[email protected]>
jefferyyjhsu
pushed a commit
to jefferyyjhsu/rclcpp
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This de-duplicates some code