remove static function rcl_ret_from_rcutils_ret(). #1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
fujitatomoya
commented
Nov 29, 2023
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@iuhilnehc-ynos can you take a look at this?
Collaborator
|
To reduce the duplication seems good to me. I think that using the common API might be the correct way, which was the reason I used To set the error message explictly if needed is a better way because we would like to keep the same consistent behavior in rcl. |
iuhilnehc-ynos
approved these changes
Nov 29, 2023
Collaborator
iuhilnehc-ynos
left a comment
iuhilnehc-ynos
left a comment
There was a problem hiding this comment.
LGTM with green CI.
Collaborator
Author
|
CI:
|
delete-merged-branch
bot
deleted the
fujitatomoya/remove-rcl_ret_from_rcutils_ret
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring to get rid of redundancy for code maintenance.