-
Notifications
You must be signed in to change notification settings - Fork 170
Timers #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mxgrey
wants to merge
19
commits into
ros2-rust:main
Choose a base branch
from
mxgrey:worker_with_timers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Timers #480
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2d20c4e
Fix merge conflicts with main
mxgrey c9c2127
Update documentation of timers
mxgrey 7ad4ece
Fix compatibility with kilted and rolling
mxgrey 802925b
Fix typo
mxgrey f24b978
Remove Cargo.lock for timers demo
mxgrey 9b6b1d1
Fix example package names
mxgrey 73b34b3
Fix name of timer demo
mxgrey 030f59c
Fix name of parameter demo
mxgrey 82f4da6
Merge remote-tracking branch 'origin/main' into worker_with_timers
mxgrey a589997
Add safety comments
mxgrey a4fa5cb
Add an explicit binary name for timer demo
mxgrey 35fa24a
Restore unsafe tag to Send trait
mxgrey 775b170
Include authors of https://github.com/ros2-rust/ros2_rust/pull/440
mxgrey 771920d
Add safety comment
mxgrey 2780db7
Finish sentence
mxgrey 2e2dce0
Timers have a dependency on Node when using NodeTime
mxgrey 421784b
Merge remote-tracking branch 'origin/main' into worker_with_timers
mxgrey 01cb7f5
Merge remote-tracking branch 'origin/main' into worker_with_timers
mxgrey 9acf2ad
Move timer_demo to examples repo
mxgrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was first confused on why there were some much commented out lines, but then I realized that this was for the documentation. Nice!