Skip to content

Removed support for the EOL galactic distro #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2023
Merged

Removed support for the EOL galactic distro #306

merged 4 commits into from
Mar 12, 2023

Conversation

@maspe36
Copy link
Collaborator

@maspe36 maspe36 commented Mar 4, 2023

The galactic distro was EOL'd on December 9th, 2022. Also worth noting that foxy will be EOL'd in May this year.

https://docs.ros.org/en/humble/Releases.html

esteve
esteve requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maspe36 awesome! Thank you so much, could you additionally bump the setup-ros action to v0.6? Then I could close #302

@maspe36
Copy link
Collaborator Author

maspe36 commented Mar 7, 2023

Bumped the version of setup-ros and copied a few other changes you had in that PR to see if I could get the builds passing, however now rolling is failing with a rustc error that I can't reproduce locally. Any ideas?

@esteve esteve mentioned this pull request Mar 9, 2023
Merged
@maspe36 maspe36 force-pushed the remove_galactic_support branch from 706aead to c04dc7b Compare March 10, 2023 23:58
@maspe36
Copy link
Collaborator Author

maspe36 commented Mar 11, 2023

@esteve Waiting on approval to merge this, rebased on #302

@maspe36 maspe36 requested a review from esteve March 11, 2023 03:18
esteve
esteve requested changes Mar 11, 2023
View reviewed changes
.github/workflows/rust.yml Outdated
uses: ros-tooling/setup-ros@v0.3
uses: ros-tooling/setup-ros@v0.6
with:
use-ros2-testing: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this? I'll prepare a PR that will enable use-ros2-testing and will fix the build issue with rolling, but this change is not necessary for removing EOL'd distros.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@esteve
Copy link
Collaborator

esteve commented Mar 11, 2023

@maspe36 only one comment, but the PR overall looks good. Could you rebase on top of main? #303 has been merged. Thanks for all the work 🙂

@maspe36 maspe36 force-pushed the remove_galactic_support branch from c04dc7b to efbf399 Compare March 11, 2023 22:24
@maspe36 maspe36 requested a review from esteve March 11, 2023 22:25
esteve
esteve approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maspe36 Thanks!

@esteve esteve merged commit 3ae0944 into ros2-rust:main Mar 12, 2023
@maspe36 maspe36 mentioned this pull request Oct 28, 2023
Closed
@esteve esteve mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esteve esteve esteve approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maspe36 @esteve