backwards-compatible fix for python3 API changes #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
force-pushed
the
pr-master-support-python3
branch
from
044587b to
a22610c
Compare
tfoote
requested changes
Nov 7, 2019
src/rosdoc_lite/msgenator.py
Outdated
| def _generate_msg_text_from_spec(package, spec, msg_context, buff=None, indent=0): | ||
| if buff is None: | ||
| buff = cStringIO.StringIO() | ||
| buff = io.StringIO() |
Member
There was a problem hiding this comment.
For full compatibility we have a conditional import to do this: http://wiki.ros.org/python_2_and_3_compatible_code
src/rosdoc_lite/landing_page.py
Outdated
| """ | ||
| config_list = [c for c in rd_configs.itervalues() if c['builder'] != 'rosmake'] | ||
| try: | ||
| rd_configs_values = rd_configs.values() |
Member
There was a problem hiding this comment.
I believe that we should be able to just use values() in both 2.7 and 3.x
src/rosdoc_lite/rdcore.py
Outdated
| """ | ||
| for k, v in tempvars.iteritems(): | ||
| try: | ||
| items = tempvars.items() |
Member
There was a problem hiding this comment.
I believe that we should be able to just use items() in both 2.7 and 3.x
v4hn
force-pushed
the
pr-master-support-python3
branch
from
a22610c to
7a5b362
Compare
Contributor
Author
|
Thanks for the review @tfoote, I addressed your feedback. |
tfoote
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remaining issues coming up when generating https://github.com/ros-planning/moveit_tutorials .
It would be nice to see a melodic release for these fixes.