enable linking to documentation hosted on third party server #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver with external Doxygen documentation using tag files
|
Thanks for contributing. Your change looks OK to me. What sort of testing do you recommend before merging it in to be picked up by the ROS build farm? |
As the result is no longer only relative, the function name is adapted and documentation added.
|
It has been a while since I opened this PR, but now I added some unit tests for my changes. Do you think, this is a good way to test the changes? |
tfoote
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosdoc_lite supports external tag files, but unlike written in ros wiki absolute urls are not supported, because the value of 'docs_url' is always interpreted as relative path.
Now there is a check whether the url is absolute (begins with http:// or https://) or not.