[Bugfix] Fix decoding on python 3 #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the changes in #108 using python3, I encountered the following error:
I believe I could not catch this on #108 unit tests because I was using a mock file, which seems not to raise any errors on write.
To fix this issue, I added a string decode logic before saving it to the file. As python2 does not have
bytesI left the python 2 version as is.@tfoote Sorry for not validating this before #108 was merged.