Default index link no homepage #240
Conversation
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
| return "[%s](%s)" % (package, package_file[package]['Homepage']) | ||
| else: | ||
| return package | ||
| return "[%s](https://index.ros.org/p/%s/#%s)" % (package, package, rosdistro) |
There was a problem hiding this comment.
Is package here $pkg_name or ros-$distro-$pkg_name?
Based on a typical output we use (example from a recent Jazzy sync announcement), this should be ros-$distro-${pkg-name}.
There was a problem hiding this comment.
Good catch, you're right.
I was making ros-infrastructure/bloom#754 as a complement to get the info into more places, but maybe that would just be a better replacement going further upstream.
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: https://discourse.openrobotics.org/t/how-do-you-access-changelogs-for-ros-2-releases/50530/2 |
|
Thanks for the quick action! My particular use-case mentioned on Discourse would prefer to add an index.ros.org link to all packages, even to those with a specified homepage. That would complicate the announcement a bit, but it would provide both the index link and the package.xml homepage if specified. E.g., currently, the announcement is:
What I propose (but I don't require the actual format):
|
|
That is not a bad suggestion. But for the first link, please consider other urls as well. Like proposed here: https://github.com/ros-infrastructure/bloom/pull/754/files#r2430814704 |
|
Right, if the index link is there in all cases, then it would make sense to default the first link to something else, e.g. the source repo. The question is whether such information is available in reprepro... |
Link to index.ros.org if homepage link unset for package announcements.