Skip to content

Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and 'command_interfaces' parameters (#967)" #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2024
Merged

Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and 'command_interfaces' parameters (#967)" #978

merged 1 commit into from
Jan 25, 2024
+3 −0

Conversation

@Noel215
Copy link
Contributor

@Noel215 Noel215 commented Jan 17, 2024

This reverts commit 6e2736b.

This should be merged after ros-controls/ros2_control#1293, which resolves the issue reported in #966.

@codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ab3759) 47.22% compared to head (792a80d) 47.61%.

❗ Current head 792a80d differs from pull request most recent head 4824871. Consider uploading reports for the commit 4824871 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   47.22%   47.61%   +0.38%     
==========================================
  Files          41       41              
  Lines        3871     3871              
  Branches     1827     1827              
==========================================
+ Hits         1828     1843      +15     
+ Misses        775      760      -15     
  Partials     1268     1268
Flag Coverage Δ
unittests 47.61% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@christophfroehlich christophfroehlich mentioned this pull request Jan 17, 2024
Closed
christophfroehlich
christophfroehlich approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

saikishor
saikishor approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Noel215

@saikishor
Copy link
Member

saikishor commented Jan 23, 2024

I think this can be merged now as ros-controls/ros2_control#1293 is merged!

@saikishor saikishor added backport-humble Triggers PR backport to ROS 2 humble. backport-iron labels Jan 24, 2024
@Noel215 Noel215 mentioned this pull request Jan 24, 2024
Merged
@destogl destogl merged commit 9f7e9e9 into ros-controls:master Jan 25, 2024
mergify bot pushed a commit that referenced this pull request Jan 25, 2024
@Noel215 @mergify
Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and …
5236c6f 
…'command_interfaces' parameters (#967)" (#978)

This reverts commit 6e2736b.

(cherry picked from commit 9f7e9e9)
mergify bot pushed a commit that referenced this pull request Jan 25, 2024
@Noel215 @mergify
Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and …
8a911ea 
…'command_interfaces' parameters (#967)" (#978)

This reverts commit 6e2736b.

(cherry picked from commit 9f7e9e9)
This was referenced Jan 25, 2024
Merged
Merged
destogl pushed a commit that referenced this pull request Jan 26, 2024
@mergify @Noel215
Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and …
5dea782 
…'command_interfaces' parameters (#967)" (#978) (#986)

This reverts commit 6e2736b.

(cherry picked from commit 9f7e9e9)

Co-authored-by: Noel Jiménez García <[email protected]>
destogl pushed a commit that referenced this pull request Jan 26, 2024
@mergify @Noel215
Revert "[JTC] Remove read_only from 'joints', 'state_interfaces' and …
ad6f25e 
…'command_interfaces' parameters (#967)" (#978) (#987)

This reverts commit 6e2736b.

(cherry picked from commit 9f7e9e9)

Co-authored-by: Noel Jiménez García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@destogl destogl destogl approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@saikishor saikishor saikishor approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@bmagyar bmagyar Awaiting requested review from bmagyar

@duringhof duringhof Awaiting requested review from duringhof

@mcbed mcbed Awaiting requested review from mcbed

@moriarty moriarty Awaiting requested review from moriarty

Assignees

No one assigned

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Noel215 @saikishor @destogl @christophfroehlich