Activate AdmittanceControllerTestParameterizedInvalidParameters #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
arne48,
bmagyar,
destogl,
duringhof,
malapatiravi and
mhubii
|
Flaky tests of JTC are addressed in #558 |
saikishor
approved these changes
Jul 18, 2023
bmagyar
approved these changes
Jul 18, 2023
8 tasks
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit 3c7072e)
bmagyar
pushed a commit
that referenced
this pull request
Aug 3, 2023
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <[email protected]> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Enable effort rejection test --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
bmagyar
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Small improvement in remapping (#393) (#724) * Fix file name for include guard (backport #681) (cherry picked from commit c619aac) Co-authored-by: Christoph Fröhlich <[email protected]> * Activate AdmittanceControllerTestParameterizedInvalidParameters (#711) (#733) * [JTC] Re-enabling test, bugfixing and hardening. Adding a parameter to define when trajectories with non-zero velocity at the end are used. (backport #705) (#706) * Add state_publish_rate parameter --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI lately complains about a test suite which is not instantiated with any TEST_P
https://github.com/ros-controls/ros2_controllers/actions/runs/5583901991/jobs/10204704127
I added a TEST_P now, but had to deactivate one invalid parameter test because SetUpController() did not fail.