Add test_depend on hardware_interface_testing
#1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
aprotyas,
bijoua29,
bmagyar,
destogl,
livanov93,
olivier-stasse and
peterdavidfagan
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
(cherry picked from commit 8bf379b) # Conflicts: # pid_controller/package.xml
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
(cherry picked from commit 8bf379b) # Conflicts: # pid_controller/package.xml
bmagyar
pushed a commit
that referenced
this pull request
Feb 5, 2024
bmagyar
pushed a commit
that referenced
this pull request
Feb 5, 2024
pac48
pushed a commit
to pac48/ros2_controllers
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the test_actuator class into a different package with ros-controls/ros2_control#1325
Now the tests here using the
ros2_control_test_assets::minimal_robot_urdffail, see here. Adding the new package to the test_depend should fix this.I also updated all includes of the test_load_*-files as well as dependencies on hardware_interface (direct include of resource_manager.hpp).
Binary jobs fail now because of ros-controls/ros2_control#1169 not being released.