-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/create supplier profile #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
end of friday -- next step ----> create relationship record linking group and supplier in relationship table after group + supplier records have been created |
f83b976 to
9dbd353
Compare
ahdinosaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoop whoop! 😸
left some comments
| @@ -0,0 +1,13 @@ | |||
| exports.up = function(knex, Promise) { | |||
| return knex.schema.table('orders', function(table){ | |||
| table.renameColumn('agentId', 'consumerAgentId') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
| import Profile from '../../agents/components/Profile' | ||
| import MemberInvites from '../../agents/components/MemberInvites' | ||
|
|
||
| const rolesToRelationships = (roles = {}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used here?
| } | ||
| } | ||
| }) | ||
| queries.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to query for relationships here?
| } | ||
| }) | ||
| }) | ||
| queryEachMember(members) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to query for this here?
| const contextAgent = getContextAgentFromTaskPlan(taskPlan) | ||
| if (isNil(contextAgent)) return true | ||
| if (anyMembersAreNil(contextAgent)) { | ||
| return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might not need this anymore.
tasks/services/plans.js
Outdated
| assigneeId: hook.data.assigneeId, | ||
| taskRecipeId: childTaskRecipe.id, | ||
| params: hook.data.params | ||
| params: JSON.stringify(params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should already be done as a before hook on the service, encodeParams in https://github.com/root-systems/cobuy/blob/master/tasks/services/plans.js#L21-L32.
…ve been created during order hook
9dbd353 to
754ebb0
Compare
|
waiting on this PR before merging |
|
this breaks the "Invite Your Members" page, but we can fix that in #148 |

closes #34
WIP
adds the Task of creating a Supplier Profile as part of the pre-reqs of signing up