Skip to content

Conversation

@iainkirkpatrick
Copy link
Member

@iainkirkpatrick iainkirkpatrick commented Aug 20, 2017

closes #34
WIP

adds the Task of creating a Supplier Profile as part of the pre-reqs of signing up

@Julietbc
Copy link
Contributor

end of friday -- next step ----> create relationship record linking group and supplier in relationship table after group + supplier records have been created

@Julietbc Julietbc changed the title [WIP] Feature/create supplier profile Feature/create supplier profile Aug 29, 2017
@Julietbc Julietbc force-pushed the feature/create-supplier-profile branch from f83b976 to 9dbd353 Compare August 29, 2017 03:15
@Julietbc Julietbc requested a review from ahdinosaur August 29, 2017 03:15
Copy link
Member

@ahdinosaur ahdinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoop whoop! 😸

left some comments

@@ -0,0 +1,13 @@
exports.up = function(knex, Promise) {
return knex.schema.table('orders', function(table){
table.renameColumn('agentId', 'consumerAgentId')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

import Profile from '../../agents/components/Profile'
import MemberInvites from '../../agents/components/MemberInvites'

const rolesToRelationships = (roles = {}) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used here?

}
}
})
queries.push({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to query for relationships here?

}
})
})
queryEachMember(members)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to query for this here?

const contextAgent = getContextAgentFromTaskPlan(taskPlan)
if (isNil(contextAgent)) return true
if (anyMembersAreNil(contextAgent)) {
return true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might not need this anymore.

assigneeId: hook.data.assigneeId,
taskRecipeId: childTaskRecipe.id,
params: hook.data.params
params: JSON.stringify(params)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should already be done as a before hook on the service, encodeParams in https://github.com/root-systems/cobuy/blob/master/tasks/services/plans.js#L21-L32.

@iainkirkpatrick iainkirkpatrick force-pushed the feature/create-supplier-profile branch from 9dbd353 to 754ebb0 Compare September 5, 2017 01:25
@iainkirkpatrick
Copy link
Member Author

waiting on this PR before merging

@ahdinosaur
Copy link
Member

this breaks the "Invite Your Members" page, but we can fix that in #148

@ahdinosaur
Copy link
Member

in the words of some old friends:

good enough for government work

good-enough-for-govt-work

@ahdinosaur ahdinosaur merged commit d17c173 into master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page: create supplier profile

4 participants