This repository was archived by the owner on Aug 4, 2021. It is now read-only.
refactor: promisify resolveId for less Promise boilerplate #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Aug 3, 2018
guybedford
approved these changes
Aug 3, 2018
| .then(resolved => { | ||
| if (options.browser && packageBrowserField) { | ||
| if (packageBrowserField[ resolved ]) { | ||
| resolved = packageBrowserField[ resolved ]; |
There was a problem hiding this comment.
This is odd for the error case, but I guess it was already doing that!
keithamus
deleted the
refactor-promisify-resolveid-for-less-promise-boilerplate
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring to make main code less boilerplatey. It removes the
new Promiseinvocation instead Promisifying theresolvepackage to make the main function easier to read (less indents!)diff without whitespace