Changes enabling using the HighResRangeFinder to more closely simulate rotating laser scanners #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
left/right_limit and resolution_horizontal belong together as do upper/lower_limit and resolution_vertical. Both resolutions had "Vertical angular resolution" for their documentation. This laser scanner does not check distances against the distance to the actual device but to the camera image plane(that crosses the actual device position).
Internally, this precalculates all sampling points instead of calculating them on the fly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding more cameras through configuration instead of only through operations, and allows using samples at the approximate intersection of the laser sweep cone(s) and the image plane(s) instead of just linearly across the image plane(s).