Fix issue 1459-Add Capture Fullpage Screenshot keyword #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the fullpage screenshot functionality requested in issue robotframework#1459. The keyword captures the entire page content by temporarily resizing the browser window to show the full page height, taking the screenshot, and then restoring the original window size. Features: - Works with all existing screenshot options (EMBED, BASE64, custom filenames) - Supports {index} placeholder for unique filenames - Includes comprehensive unit and acceptance tests - Follows same patterns as existing screenshot keywords This is useful for capturing long pages that require scrolling to see all content, especially helpful for debugging test failures.
|
Ready for review - Implements fullpage screenshot functionality as requested in issue #1459. All tests passing, ready for maintainer review. Thanks! |
|
@certainly-param What happens when the screen size is limited to less than the full page size? Will this still capture the full size or not? I could see there being some issues here with limited screen sizes. |
…tive support - Add Chrome DevTools Protocol (CDP) method for Chrome/Edge browsers Works in both headless and non-headless mode without screen size limits - Add Firefox native full-page screenshot support - Implement browser detection and capability checking - Use strategy pattern with automatic fallback to window resize method - Window resize method validates actual dimensions and warns on limitations - Update documentation to describe the three screenshot strategies - Resolves screen size limitation concerns in non-headless mode
certainly-param
force-pushed
the
fix-issue-1459
branch
from
764e474 to
ed5bf0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1459
Implements the fullpage screenshot functionality requested in issue #1459.
The keyword captures the entire page content by temporarily resizing
the browser window to show the full page height, taking the screenshot,
and then restoring the original window size.
Features:
This is useful for capturing long pages that require scrolling to see
all content, especially helpful for debugging test failures.
Closes #1459