Merge v0.30 changes back to main #320
Conversation
…or-release # Conflicts: # version.json
📝 WalkthroughWalkthroughThis pull request introduces two new analyzer rules for the Moq.Analyzers package: Moq1400 and Moq1410. The changes involve updating documentation across multiple files to describe these new rules. Moq1400 encourages developers to explicitly choose a mocking behavior instead of using the default Loose behavior, while Moq1410 advises setting the Strict mocking behavior. The changes include updates to the README.md, documentation files, and analyzer release tracking documents. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
README.md(1 hunks)docs/rules/Moq1410.md(0 hunks)src/Analyzers/AnalyzerReleases.Shipped.md(1 hunks)src/Analyzers/AnalyzerReleases.Unshipped.md(0 hunks)
💤 Files with no reviewable changes (2)
- src/Analyzers/AnalyzerReleases.Unshipped.md
- docs/rules/Moq1410.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (windows-latest)
🔇 Additional comments (1)
src/Analyzers/AnalyzerReleases.Shipped.md (1)
69-70: Verify documentation links.The documentation links follow the correct pattern, but let's verify they exist in the repository.
✅ Verification successful
Documentation links are valid and content is complete
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that documentation files exist for the new rules # Check if documentation files exist for doc in docs/rules/Moq{1400,1410}.md; do if [ ! -f "$doc" ]; then echo "Missing documentation: $doc" exit 1 fi doneLength of output: 161
Script:
#!/bin/bash # Display content of both documentation files echo "=== Moq1400.md ===" cat docs/rules/Moq1400.md echo -e "\n=== Moq1410.md ===" cat docs/rules/Moq1410.mdLength of output: 4548
This fixes a regression caused by #290. `Microsoft.CodeAnalysis.AnalyzerUtilities` is not one of the assemblies provided by the host (i.e. compiler), so we need to include it in our own package. I'm not sure how to write an automated test for this. Our current tests don't use the NuGet package. Doing something like `dotnet format` in theory should work, but when I tried that it passed even without this change. This does result in a new package contents baseline, so we can chalk this one up to reviewer error and revisit if we find a better solution.
# Conflicts: # version.json
|
Code Climate has analyzed commit c1a6db8 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Summary by CodeRabbit
New Features
Documentation
Chores