fix: update xrpl dev dependency to 4.2.5 #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
approved these changes
Apr 22, 2025
ckeshava
approved these changes
Apr 22, 2025
| const holder = tx.Holder | ||
| const amount = findAssetAmount(meta, tx.Asset, tx) | ||
| if (tx.Flags) { | ||
| // @ts-expect-error - MPT is not being supported for AMM transactions until https://github.com/XRPLF/rippled/pull/5285 is merged |
Contributor
There was a problem hiding this comment.
I'm surprised that you are getting these Typescript transpiler errors in this PR. They must have been observed in prior PRs too.
Did you upgrade your ts-node version?
Collaborator
Author
There was a problem hiding this comment.
This PR was included in 4.2.5:
XRPLF/xrpl.js#2919
Which breaks the current code type-check due to MPT formatted differently.
However, MPT is not supported for AMM transactions until XRPLF/rippled#5285 is released. So once that is merged we can make necessary changes to both xrpl.js and Explorer
For now it would not break anything, other than type-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Versions 4.2.1 -> 4.2.4 of xrpl were compromised. Set the caret version to the latest rectified version 4.2.5.
Type of Change