Bug: undo after ClangFormat does undo twice, erasing previous changes

[aravind2612krishna]

Neovim, windows.
To reproduce :
In the simple file below, try changing Hello to something else, then selecting the lines and doing a clang format.
Then, doing an Undo undoes the Hello change as well.

[Kypert]

I think I have a local fix for this, can prepare a PR tomorrow. Would it be possible for you to try it out?

[aravind2612krishna]

Least I can do. Thanks

[Kypert]

Met some unexpected issues when I added a small unit test for the issue at hand. Still works in my normal environment though. Will continue tomorrow.

…

On Fri, 17 Apr 2020, 08:02 aravind2612krishna, ***@***.***> wrote: Least I can do. Thanks — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJB5UQRC7HZAJRU26B2CBXLRM7WGVANCNFSM4MHPPDDA> .

[Kypert]

@aravind2612krishna, while I still have issues in the test, it works for my normal vim/nvim instance. At your convenience, it would be valuable it you could try it out and see if the fix is also valid in your setup.

[aravind2612krishna]

I tried with the plugin from 'Kypert/vim-clang-format', but similar behavior persists.

[Kypert]

Interesting, just to make sure, did you use the fix branch:

Plug 'Kypert/vim-clang-format', { 'branch' : 'fix/issues/98' }

[aravind2612krishna]

Apologies. It does work in that branch, I just tried.

[guyben13]

Do you know why the undojoin is there?

[csmartdalton]

Can this PR be accepted? I have this same issue with undos