feat: avoid downloading attachments ourselves #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 17, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 17, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
gabrielmfern
pushed a commit
that referenced
this pull request
Oct 21, 2025
lucasfcosta
added a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed on our daily yesterday that downloading files on behalf of our users limits their capabilities to use them as Buffers without extra work as it's probably not the majority of users that will want to use them as base64 directly.
We can eventually discuss a
downloadmethod or something along those lines.