Skip to content

Conversation

@TyMick
Copy link
Contributor

@TyMick TyMick commented Oct 8, 2025

The example in the error message isn't actually compliant with the rules. Most confusingly to me, the title portion after the colon started with a capital letter, while the rules require it to start with a lowercase letter. But while I'm at it, I figured we may as well use feat as the example's type instead of type, since type isn't an allowed type.


Summary by cubic

Updates the PR title check error message to show a compliant example that matches our rules. Uses "feat: my PR title" to reflect allowed types and the lowercase-after-colon requirement.

@TyMick TyMick requested a review from a team as a code owner October 8, 2025 03:52
@TyMick TyMick requested a review from bukinoshita October 8, 2025 03:52
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@TyMick TyMick force-pushed the pr-title-check-error branch 3 times, most recently from 6eb8ed1 to 7120123 Compare October 9, 2025 04:34
The example in the error message isn't actually compliant with the
rules. Most confusingly to me, the title portion after the colon started
with a capital letter, while the rules require it to start with a
lowercase letter.

Co-authored-by: Gabriel Miranda <[email protected]>
@TyMick TyMick force-pushed the pr-title-check-error branch from 7120123 to 5e9451f Compare October 9, 2025 04:35
@gabrielmfern gabrielmfern merged commit b0491c4 into resend:canary Oct 9, 2025
7 checks passed
gabrielmfern added a commit that referenced this pull request Oct 16, 2025
gabrielmfern added a commit that referenced this pull request Oct 17, 2025
lucasfcosta pushed a commit that referenced this pull request Oct 17, 2025
gabrielmfern added a commit that referenced this pull request Oct 21, 2025
gabrielmfern added a commit that referenced this pull request Oct 21, 2025
lucasfcosta pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants