- 
                Notifications
    
You must be signed in to change notification settings  - Fork 59
 
chore: improve PR title check error #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
              
                    gabrielmfern
  
              
              reviewed
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
6eb8ed1    to
    7120123      
    Compare
  
    The example in the error message isn't actually compliant with the rules. Most confusingly to me, the title portion after the colon started with a capital letter, while the rules require it to start with a lowercase letter. Co-authored-by: Gabriel Miranda <[email protected]>
7120123    to
    5e9451f      
    Compare
  
    
              
                    gabrielmfern
  
              
              approved these changes
              
                  
                    Oct 9, 2025 
                  
              
              
            
            
    
  gabrielmfern 
      added a commit
      that referenced
      this pull request
    
      Oct 16, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
    
  gabrielmfern 
      added a commit
      that referenced
      this pull request
    
      Oct 17, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
    
  lucasfcosta 
      pushed a commit
      that referenced
      this pull request
    
      Oct 17, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
    
  gabrielmfern 
      added a commit
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
    
  gabrielmfern 
      added a commit
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
    
  lucasfcosta 
      pushed a commit
      that referenced
      this pull request
    
      Oct 27, 2025 
    
    
      
  
    
      
    
  
Co-authored-by: Gabriel Miranda <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
The example in the error message isn't actually compliant with the rules. Most confusingly to me, the title portion after the colon started with a capital letter, while the rules require it to start with a lowercase letter. But while I'm at it, I figured we may as well use
featas the example's type instead oftype, sincetypeisn't an allowed type.Summary by cubic
Updates the PR title check error message to show a compliant example that matches our rules. Uses "feat: my PR title" to reflect allowed types and the lowercase-after-colon requirement.