Skip to content

Don't format and don't check formatting of dependencies #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

Don't format and don't check formatting of dependencies #7748

merged 2 commits into from
Aug 1, 2025

Conversation

mediremi
Copy link
Member

@mediremi mediremi commented Aug 1, 2025

Closes #7747

@mediremi mediremi marked this pull request as ready for review August 1, 2025 12:01
fhammerschmidt
fhammerschmidt approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nojaf
nojaf approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.
Will try out later this weekend and then merge.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 1, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7748

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7748

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7748

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7748

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7748

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7748

commit: 70e9f29

@nojaf nojaf merged commit 93b103d into rescript-lang:master Aug 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewatch: format --all --check checks formatting of node_modules dependencies
3 participants
@mediremi @nojaf @fhammerschmidt