Skip to content

Add RegExp.flags external and corresponding tests #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

Add RegExp.flags external and corresponding tests #7461

merged 4 commits into from
May 21, 2025

Conversation

jmagaram
Copy link
Contributor

@jmagaram
Copy link
Contributor Author

I couldn't get things to build and the code space didn't work. but I think this code works and someone else can easily fix it.

@jmagaram jmagaram mentioned this pull request May 10, 2025
Open
@zth zth force-pushed the core-regex-flags branch from 92c284b to 5f39233 Compare May 21, 2025 15:52
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 21, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7461

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7461

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7461

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7461

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7461

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7461

commit: a74cb23

@zth zth force-pushed the core-regex-flags branch from 3ee1c6f to fe21a0e Compare May 21, 2025 16:47
@zth zth enabled auto-merge (squash) May 21, 2025 16:47
@zth zth self-requested a review May 21, 2025 16:48
@zth zth merged commit febf7cb into rescript-lang:master May 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagaram @zth