Skip to content

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Mar 10, 2023

This reverts commit e9b20ae.

We want to be on the latest setup-ocaml version, as the new ocaml-setup 2.0.12 now also uses the official OPAM mingw repo instead of the deprecated and outdated fork fdopen/opam-repository-mingw.

@cknitt cknitt requested a review from cristianoc March 10, 2023 07:17
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't is better to freeze the version, to avoid breakages like the last one to happen in future?
Or is it worth taking the risk in exchange for automatic updates?

@cknitt
Copy link
Member Author

cknitt commented Mar 10, 2023

I prefer having automatic updates. Of course, breakages can never be ruled out, but are usually easy to diagnose and fix by temporarily pinning the version like we just did.

When freezing the version, breakages cannot be ruled out either, as the world around us changes, too, which can cause older versions to stop working while newer version have already been adapted.

@cknitt cknitt merged commit 718efe6 into rescript-lang:master Mar 10, 2023
@cknitt cknitt deleted the latest-setup-ocaml branch March 10, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants