Skip to content

Fix parsing not atomic expression in spread props of JSX #5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2022
Merged

Fix parsing not atomic expression in spread props of JSX #5885

merged 4 commits into from
Dec 8, 2022

Conversation

mununki
Copy link
Member

@mununki mununki commented Dec 7, 2022

This PR fixes #5882

@mununki
Copy link
Member Author

mununki commented Dec 7, 2022

@cknitt I'm not sure about the change log. Let me know if it needs to be fixed as sync to the change log in 10.1_release branch.

@mununki
Copy link
Member Author

mununki commented Dec 7, 2022

Forgot to mentioned that this change is already merged in the syntax repo. rescript-lang/syntax#721

@mununki
Copy link
Member Author

mununki commented Dec 7, 2022

The updating change log seems already done in #5884 (comment). If this PR doesn't need to update the change log in the compiler, let me know.

@cknitt
Copy link
Member

cknitt commented Dec 7, 2022

Please rebase to latest master, the Windows build should work now.

@mununki mununki force-pushed the fix-parse-spread-props branch from 2d9e851 to c63432e Compare December 7, 2022 22:59
@mununki
Copy link
Member Author

mununki commented Dec 7, 2022

Please rebase to latest master, the Windows build should work now.

Thanks! Rebased to master.

@cknitt
Copy link
Member

cknitt commented Dec 8, 2022 •
edited
Loading

Could you rebase to lastest master again and have the changelog update go to 10.1.1?

@mununki
Copy link
Member Author

mununki commented Dec 8, 2022

Could you rebase to lastest master again and have the changelog update go to 10.1.1?

Sure no problem, then I'll move the change log to under 10.1.1.

@mununki mununki force-pushed the fix-parse-spread-props branch from c63432e to b9cf5d2 Compare December 8, 2022 08:27
@mununki
Copy link
Member Author

mununki commented Dec 8, 2022

Could you rebase to lastest master again and have the changelog update go to 10.1.1?

Rebased to the latest master and move the log in the CHANGELOG.md

@mununki mununki merged commit d715bfd into master Dec 8, 2022
@mununki mununki deleted the fix-parse-spread-props branch December 8, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cknitt cknitt cknitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSX props spread with pipe is printed as invalid code

2 participants

@mununki @cknitt