Skip to content

Print error message when ? is used for non-optional fields. #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2022
Merged

Print error message when ? is used for non-optional fields. #5853

merged 2 commits into from
Nov 27, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Nov 27, 2022

Backported to 10.1

@cknitt cknitt requested a review from cristianoc November 27, 2022 07:36
cristianoc
cristianoc approved these changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog?

@cknitt cknitt merged commit 14e999e into rescript-lang:10.1_release Nov 27, 2022
@cknitt cknitt deleted the redundant-question-field-10.1 branch November 27, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cknitt @cristianoc