Skip to content

Jsxtags: shaded brackets in JSX, just like TS does. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 42 commits into from
Closed

Jsxtags: shaded brackets in JSX, just like TS does. #368

wants to merge 42 commits into from

Conversation

cristianoc
Copy link
Collaborator

No description provided.

cristianoc and others added 30 commits March 9, 2022 13:52
@cristianoc
Test vendoring the entire parser.
b2d5ca3
@cristianoc
Complete vendoring of necessary compiler libs.
af57911
@cristianoc
Add test command to parse a file.
1d3515e
@cristianoc
Separate parser test.
8b3a4e7
@cristianoc
Add part of core logic to recognise JSX uppercase/lowercase, type arg…
e42016c 
…uments, binary operators.
@cristianoc
Basic setup of extension analysis bin communication.
9b7d8d9 
From https://github.com/zth
@cristianoc
Simple token emitter
d854773
@cristianoc
Pass current file contents to binary command.
5fb6fc2
@cristianoc
Use an ast mapper.
6fca52b
@cristianoc
Semantic highlighting for JSX open and close.
2bf41ca
@cristianoc
Emit variables.
7d18906
@cristianoc
Add token type "variable".
142d03d
@cristianoc
Emitting types too.
547ae25
@zth
add sample highlight files
3c5119b
@zth
add explicit semantic token for JSX tag
31b603e
@cristianoc
Emit long idents in expressions, patterns, and jsx labels, uniformly.
77dae25 
With upper case ids, emit Token.JsxTag
With lower case ids, emit Token.Variable

Still need to do module declarations and expressions (and e.g. open M etc).
@cristianoc
Rename JsxTag to Module.
40a1511
@cristianoc
Other cases of module declarations and expressions.
73879ae
@cristianoc
For module types, use Token.Type.
ede6f86
@cristianoc
Add token type to debug print.
8658618
@cristianoc
Use JsxTag for lower-case jsx, and Namespace for modules.
4faa239
@cristianoc
Extend example file.
8ec7e31
@cristianoc
Extend example.
6645df7
@cristianoc
Emit record labels as "property".
cc4a0d3
@cristianoc
Emit variants as enumMember.
a91494f
@zth
change let coloring to keyword, not control
d4ceba1
@zth
Merge branch 'semantic-highlighting' of github.com:zth/rescript-vscod…
2140178 
…e into semantic-highlighting
@zth
more samples
a9de07c
@cristianoc
Fix issue with function definitions that use labeled arguments.
e12db8d
@cristianoc
tweak example file
61408d5
@cristianoc
Tweak test: nested.
228374c
@cristianoc
Fix issue with closing tag of nested components.
b44828c
@cristianoc
Semantic highlighting: show brackets in jsx like TypeScript does.
9db5562 
This is done in two places:
The textmate grammar handles the cases that can be figured out locally:
- "<" in "<div ..."
- "</"
- "/>"
- "<>"
- "</>"

Semantic highlighting handles the cases that cannot be figured out locally:
- ">" in "<div __props__>"
- ">" in "</div>"

These cases can't be figures out locally as on the lhs of ">" there could be pretty much anything.
@cristianoc cristianoc closed this Mar 16, 2022
@cristianoc cristianoc deleted the jsxtags branch March 16, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianoc @zth