-
-
Notifications
You must be signed in to change notification settings - Fork 254
Draft: let? blog post #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Draft: let? blog post #1093
Conversation
Deploying rescript-lang-org with
|
Latest commit: |
7c30336
|
Status: | ✅ Deploy successful! |
Preview URL: | https://06b49055.rescript-lang.pages.dev |
Branch Preview URL: | https://roadmap-let-unwrap.rescript-lang.pages.dev |
9bfb0c6
to
68931f9
Compare
Assistant:
looks spot on to me |
Seems legit, except the last suggestion might be too much |
Btw |
68931f9
to
156ad3c
Compare
->Result.flatMapOkAsync(decodedUser => ensureUserActive(decodedUser)) | ||
``` | ||
|
||
**Note**: `Result.flatMapOkAsync` among some other async result helper functions are brand new in ReScript 12 as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I think it’s ready to go.
One feeling I still get is that it reads like a new idea we haven't really tested in our codebase. I'm not sure if that's an issue or worth mentioning, but it's hard to tell whether this will be game-changing or not.
Closes #1086