Skip to content

Map, Set, WeakMap, WeakSet: use types from Js namespace #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2023
Merged

Map, Set, WeakMap, WeakSet: use types from Js namespace #143

merged 2 commits into from
May 28, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 28, 2023

Placeholder types for ES6 collections were added to the Js namespace in rescript-lang/rescript#5630.

We should use these in Core.

@cknitt cknitt requested review from zth and cristianoc May 28, 2023 18:39
zth
zth approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a changelog?

@cknitt cknitt mentioned this pull request May 28, 2023
Closed
@zth zth merged commit 7d498f7 into main May 28, 2023
@zth zth deleted the use-js-collection-types branch May 28, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cristianoc cristianoc Awaiting requested review from cristianoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @zth