Skip to content

Conversation

@sophieklm
Copy link
Contributor

There has been a new release of tough-cookie to fix the following:

The tough-cookie module is vulnerable to regular expression denial of service. Input of around 50k characters is required for a slow down of around 2 seconds.

Unless node was compiled using the -DHTTP_MAX_HEADER_SIZE= option the default header max length is 80kb so the impact of the ReDoS is limited to around 7.3 seconds of blocking.

At the time of writing all version <=2.3.2 are vulnerable

See: https://nodesecurity.io/advisories/525

@coveralls
Copy link

coveralls commented Sep 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7f2bff2 on sophieklm:tough-cookie-update into 7239e1e on request:master.

@analog-nico analog-nico merged commit 1b7306e into request:master Sep 22, 2017
@analog-nico
Copy link
Member

Thanks a lot @sophieklm ! I just published [email protected] which includes the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants