fix: Leather Wallet network mismatch #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6d015d The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Leather wallet integration where Bitcoin transactions were incorrectly targeting the mainnet instead of the testnet when using the Bitcoin testnet network. The fix updates the Leather wallet connector to properly pass the network parameter and use the correct API types.
- Updates Leather wallet connector to include network parameter in transfer requests
- Upgrades @leather.io/rpc dependency to use newer API types
- Adds test coverage for testnet transaction handling
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/adapters/bitcoin/src/connectors/LeatherConnector.ts | Updated transfer parameters to include network and use new API types |
| packages/adapters/bitcoin/tests/connectors/LeatherConnector.test.ts | Added testnet test case and updated existing test expectations |
| packages/adapters/bitcoin/package.json | Upgraded @leather.io/rpc dependency version |
| packages/appkit/exports/constants.ts | Bumped package version to 1.8.8 |
| apps/demo/package.json | Updated demo app dependencies to version 1.8.8 |
| package.json | Updated strip-ansi version constraint |
| .changeset/large-doors-drive.md | Added changeset documenting the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tomiir
changed the title
enesozturk
reviewed
Oct 7, 2025
enesozturk
reviewed
Oct 7, 2025
enesozturk
approved these changes
Oct 7, 2025
lukaisailovic
approved these changes
Oct 7, 2025
…00-rootstock-powpegbug-when-using-bitcoin-testnet-network-and
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tomiir
deleted the
tomas/apkt-4000-rootstock-powpegbug-when-using-bitcoin-testnet-network-and
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Associated Issues
Closes APKT-4000
Checklist
Note
Fixes Leather wallet connector to target the correct Testnet network and adds unit tests; minor config/package updates.
packages/adapters/bitcoin/src/connectors/LeatherConnector.tsto correctly target Testnet.packages/adapters/bitcoin/tests/connectors/LeatherConnector.test.tsto cover Testnet targeting behavior.packages/adapters/bitcoin/package.jsonandapps/demo/package.json(version/scripts/deps as needed).apps/laboratory/.eslintrc.json.Written by Cursor Bugbot for commit b6d015d. This will update automatically on new commits. Configure here.