DO NOT MERGE - BTC logs #5162
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -308,10 +308,15 @@ export class BitcoinAdapter extends AdapterBlueprint<BitcoinConnector> { | |||||||||||||||||||||||||||||||||||||||||||||||||||||
| ): Promise<AdapterBlueprint.SignMessageResult> { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const connector = params.provider as BitcoinConnector | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| console.log('>> Bitcoin Adapter: Connector', connector) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (!connector) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| throw new Error('BitcoinAdapter:signMessage - connector is undefined') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| console.log('>> Bitcoin Adapter: Signing Message') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| console.log('>> Bitcoin Adapter: Connector.signMessage', connector.signMessage) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+311
to
+319
There was a problem hiding this comment. Debug console.log statements should not be committed to production code. Consider using a proper logging framework or removing these statements before merging.
Suggested change
Comment on lines
+311
to
+319
There was a problem hiding this comment. Debug console.log statements should not be committed to production code. Consider using a proper logging framework or removing these statements before merging.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| const signature = await connector.signMessage({ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| message: params.message, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| address: params.address | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -706,6 +706,7 @@ | |||||
| return ids.some(id => Boolean(window.ethereum?.[String(id)])) | ||||||
| }, | ||||||
| signMessage: async (message: string) => { | ||||||
| console.log('>> Signing Message') | ||||||
|
There was a problem hiding this comment. Debug console.log statements should not be committed to production code. Consider using a proper logging framework or removing these statements before merging. |
||||||
| const namespace = ChainController.state.activeChain | ||||||
| const adapter = this.getAdapter(ChainController.state.activeChain) | ||||||
|
|
||||||
|
|
@@ -717,12 +718,18 @@ | |||||
| throw new Error('signMessage: adapter not found') | ||||||
| } | ||||||
|
|
||||||
| console.log('>> Adapter', adapter) | ||||||
| console.log('>> Namespace', namespace) | ||||||
|
|
||||||
| const address = this.getAddress(namespace) | ||||||
| console.log('>> Address', address) | ||||||
|
There was a problem hiding this comment. Debug console.log statements should not be committed to production code. Consider using a proper logging framework or removing these statements before merging.
Suggested change
|
||||||
|
|
||||||
| if (!address) { | ||||||
| throw new Error('signMessage: address not found') | ||||||
| } | ||||||
|
|
||||||
| console.log('>> Provider', ProviderController.getProvider(namespace)) | ||||||
|
There was a problem hiding this comment. Debug console.log statements should not be committed to production code. Consider using a proper logging framework or removing these statements before merging.
Suggested change
|
||||||
|
|
||||||
| const result = await adapter?.signMessage({ | ||||||
| message, | ||||||
| address, | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Bitcoin Adapter Contains Unnecessary Debug Logs
The
signMessagemethod in the Bitcoin adapter includes severalconsole.logdebugging statements. These appear to be temporary logs, as indicated by the PR title "DO NOT MERGE - BTC logs", and shouldn't be part of the final codebase.