Add session package #10822
Merged
Add session package #10822
+1,440
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjackson
force-pushed
the
session
branch
2 times, most recently
from
09ba3d0 to
a28d440
Compare
brophdawg11
reviewed
Nov 6, 2025
Contributor
brophdawg11
left a comment
brophdawg11
left a comment
There was a problem hiding this comment.
Looks good! I like the cleaner decoupling of the cookie/session and the new storage APIs of update/delete instead of commitSession/destroySession 👍
Also, sessions must now be "started" by using the session() middleware before they can be used.
brophdawg11
reviewed
Nov 7, 2025
Comment on lines
+116
to
+118
| get size(): number { | ||
| return this.#valueMap.size + this.#flashMap.size | ||
| } |
Contributor
There was a problem hiding this comment.
Did we end up using this for anything?
Member
Author
There was a problem hiding this comment.
Nah, I ended up adding a context.sessionStarted flag instead and issuing a warning if someone starts using context.session without a session() middleware in the stack since it's a no-op. I still think session.size is a nice-to-have though, so I left it in.
brophdawg11
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
@remix-run/sessionpackage and asessionmiddleware tofetch-router.It's a complete rewrite of the session handling code we currently have in Remix v2 and RR v7. The main motivations for this work were:
session.flash()valuesFileSessionStoragefor storing sessions on the filesystemThis PR closes #10790 and #10794, and supersedes #10811