Skip to content

Conversation

@pcattori
Copy link
Contributor

@pcattori pcattori commented Sep 3, 2024

client dep optimization pass for local dev

in that case, the module graph is treated like a client-module graph without any transforms, so we need to disable the .server detection during deps discovery

in the future, it would be better to have separate module graphs for client and server without requiring transforms so that this all works with Vite out-of-the-box and server dependencies are not optimized for use by the client

See remix-run/remix#9921

client dep optimization pass for local dev

in that case, the module graph is treated like a client-module graph
without any transforms, so we need to disable the `.server` detection
during deps discovery

in the future, it would be better to have separate module graphs for
client and server without requiring transforms so that this all works
with Vite out-of-the-box and server dependencies are not optimized for
use by the client
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: fcd11ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit 26cc9d9 into dev Sep 4, 2024
@pcattori pcattori deleted the pedro/disable-dot-server-detection-for-optimize-deps branch September 4, 2024 00:55
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants