-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
feat: allow overriding matchPath function on Routes #11556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Hi @modi98, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Is it required to have all the bundles stay within the 5% range of current file size? I see it's failing because of a small bump on bundle size, which I'm not even sure could be removed. I'm assuming the bundle size increades a few bytes through the added imports of |
|
Thank you for the POC implementation! I'm going to close this out as it's not yet been accepted as a proposed feature - but we'll have the link to this closed PR in the Proposal if it ends up being accepted and we want to re-open. In the meantime, you can always use |
This change allows users to override the base
matchPathused by theRoutescomponent. This will allow people to progressively migrate from the removal of validators and regex on paths that used to exist before v6.This is a simple example of an implementation of a
customMatchPathfunction (open to change the name) which could be further developed to usepath-to-regexpor other library for path matching.#11546