Dashboard Rewrite PR #144
Draft
Dashboard Rewrite PR #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs improvement + functionalities
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| #isValidUrl(str) { | ||
| var pattern = new RegExp('^(https?:\\/\\/)?'+ // protocol | ||
| '((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|'+ // domain name |
Check failure
Code scanning / CodeQL
Inefficient regular expression
Member
Author
There was a problem hiding this comment.
Will fix later, probably
added removing of songs, rearranging, "shifting", current song metadata All queue features implemented
ShadowLp174
temporarily deployed
to
github-pages
ShadowLp174
temporarily deployed
to
github-pages
| app.use(express.json()); | ||
| app.use(express.urlencoded()); | ||
| app.use(express.static(path.join(__dirname, "/static"))); | ||
| app.use(cookieParser()); |
Check failure
Code scanning / CodeQL
Missing CSRF middleware
Comment on lines
+52
to
+57
| const ses = session({ | ||
| secret: remix.config.sessionSecret || this.guid(), | ||
| resave: false, | ||
| secure: !!remix.config.ssl.useSSL, | ||
| saveUninitialized: false | ||
| })); | ||
| }); |
Check warning
Code scanning / CodeQL
Clear text transmission of sensitive cookie
- prominent thumbnail image colour picker interface done - interface for channel display - current song display now connected to updates from the websocket - queue syncing on load and join - playback status syncing - other improvements
initiated text channel selection (not fully done yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR draft for dashboard rewrite commits