Make sure AFLAGS are always accessible by parent across CMake reruns. #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This does not have to be cached because ARCH is already cached... or am I missing something? |
|
I noticed this issue while working on the test scenarios we discussed: https://pastebin.com/DR6PnDwY |
|
I get it, but I don't see how the current behavior creates problems. On the other hand, caching one more variable takes space in the |
|
Re. behavior, when CMake reruns for any reason, the -m32/-m64 flags are gone from the compiler invocation according to my tests. Is that intentional/acceptable? |
AmineKhaldi
force-pushed
the
aflags_fix
branch
from
37c51bb to
9a726ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.