Skip to content

Fix declaration in .d.ts file #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fix declaration in .d.ts file #30

merged 1 commit into from
Aug 26, 2021

Conversation

@ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Aug 25, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

resolves

node_modules/rehype-react/index.d.ts:13:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

13 const rehypeReact: Plugin<[Options], Root, ReactElement<unknown>>
   ~~~~~

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix labels Aug 25, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 25, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy mentioned this pull request Aug 26, 2021
Draft
14 tasks
@wooorm wooorm changed the title types: use declare in d.ts file Fix declaration in .d.ts file Aug 26, 2021
@wooorm wooorm merged commit 28c6279 into rehypejs:main Aug 26, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 26, 2021
@ChristianMurphy ChristianMurphy deleted the types/use-declare-in-dts branch August 26, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristianMurphy @codecov-commenter @wooorm