Skip to content

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 17, 2021

Context: refined-github/refined-github#4472

Possible improvements:

  • Add isProfile #95, which just checks github-reserved-names against a no-slash URL
  • Find better meta tag without having to use !isOrganizationProfile()
  • Ensure it works on all tabs and never includes the org profile

Possible "better meta tag" ideas

  • twitter:title has - overview in the user, but it doesn't sound super safe

    Screen Shot 12 Screen Shot 10
  • analytics-location sounds great

    Screen Shot 13 Screen Shot 14

@fregante fregante added the enhancement New feature or request label Jun 17, 2021
@fregante fregante added the help wanted Extra attention is needed label Aug 6, 2021
@fregante fregante marked this pull request as ready for review September 25, 2021 09:22
@fregante fregante force-pushed the fast-is-user-profile branch from 5b7a1f3 to cbfa4eb Compare September 25, 2021 09:40
@fregante fregante changed the title Make isUserProfile use faster meta tags Use faster detections for profiles Sep 25, 2021
@fregante fregante changed the title Use faster detections for profiles Use faster detections for user profiles Sep 25, 2021
@fregante fregante merged commit e31c170 into main Sep 25, 2021
@fregante fregante deleted the fast-is-user-profile branch September 25, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

Successfully merging this pull request may close these issues.

1 participant