Skip to content

Conversation

yakov116
Copy link
Member

Fixes #69

@yakov116 yakov116 added bug Something isn't working enhancement New feature or request labels Apr 22, 2021
@yakov116
Copy link
Member Author

@fregante any idea why its timing out?

@fregante
Copy link
Member

Can you move the ava timeout configuration from the npm script to the “ava” section in package.json? GHA calls AVA directly, not the script

@yakov116
Copy link
Member Author

🤷

@fregante
Copy link
Member

fregante commented Apr 22, 2021

It’s recursively calling itself. You can’t use getRepo inside isRepo

@yakov116
Copy link
Member Author

It’s recursively calling itself. You can’t use getRepo inside isRepo

duh!!

@fregante
Copy link
Member

There’s another of those checks inside isRepo with the same problem. Check how it was solved. I think isRepoSearch

@fregante
Copy link
Member

It’s annoying that the test error was useless until you increased the timeout considerably and the “max stack” error was visible.

@yakov116 yakov116 requested a review from fregante April 22, 2021 03:30
@fregante
Copy link
Member

LGTM

@yakov116 yakov116 merged commit 861aabf into master Apr 22, 2021
@yakov116 yakov116 deleted the isNewRepoTemplate branch April 22, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Template generation page should not be part of isRepo
2 participants