isProject - Add support for organization projects
#208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
approved these changes
May 9, 2025
fregante
changed the title
isProjectisProject - Add support for organization projects (#208)
fregante
reviewed
May 9, 2025
| @@ -202,9 +202,10 @@ export const isOwnUserProfile = (): boolean => getCleanPathname() === getLoggedI | |||
| // If there's a Report Abuse link, we're not part of the org | |||
| export const isOwnOrganizationProfile = (): boolean => isOrganizationProfile() && !exists('[href*="contact/report-abuse?report="]'); | |||
|
|
|||
| export const isProject = (url: URL | HTMLAnchorElement | Location = location): boolean => /^projects\/\d+/.test(getRepo(url)?.path); | |||
| export const isProject = (url: URL | HTMLAnchorElement | Location = location): boolean => /^projects\/\d+/.test(getRepo(url)?.path ?? getOrg(url)?.path); | |||
| TEST: addTests('isProject', [ | |||
| 'https://github.com/sindresorhus/refined-github/projects/3', | |||
There was a problem hiding this comment.
We should update the URL to one that exists
Suggested change
| 'https://github.com/sindresorhus/refined-github/projects/3', | |
| 'https://github.com/orgs/eslint/projects/4', |
There was a problem hiding this comment.
If you apply this change, most likely you'll have to update the URL to other parts as well
fregante
changed the title
isProject - Add support for organization projects (#208)isProject - Add support for organization projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this and then update
no-modalsfeature.