Skip to content

Conversation

@fregante
Copy link
Member

fregante commented Aug 15, 2023

The original 404 page had zero UI so the whole extension was disabled, with the exception of useful-not-found-page.

These new 404 pages are actually just repo pages that have a "not found" area, so they still benefit from a host of other repo-wide features like bugs-tab and ci-link

To fix refined-github/refined-github#6413, we need to have a separate isFile404 detection, perhaps, and then add a new init in useful-not-found-page to handle this new view.

@fregante
Copy link
Member

Generic Screenshot
File Screenshot 1

@134130
Copy link
Contributor Author

134130 commented Aug 15, 2023

I'll fix this branch as detecting isFile404

@fregante fregante changed the title Fix: is404() not detecting new 404 pages Add isFile404 Aug 17, 2023
@fregante fregante merged commit 1c47d12 into refined-github:main Aug 17, 2023
@134130 134130 deleted the fix/404 branch August 18, 2023 00:26
@fregante fregante changed the title Add isFile404 Add isRepoFile404 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants