Skip to content

Earlier detection for isPublicRepo #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

ambujsahu81
Copy link
Contributor

Description

  • The changes update the isPublicRepo method to use octolytics-dimension-repository_public meta tag.
  • Fixes #151.

Tests with refined-github extension

  • Previous implementation produced an minor issuse.
    minorBugWithIsPublicRepo

  • After changes, test with public repo
    testPublicRepo

  • test with a private repo
    testPrivateRepo

Co-authored-by: Federico Brigante <[email protected]>
@fregante fregante changed the title Use meta tags in isPublicRepo Earlier detection for isPublicRepo Mar 20, 2023
@fregante fregante merged commit 36b825e into refined-github:main Mar 20, 2023
@fregante
Copy link
Member

Thank you! I had forgotten about this PR

@ambujsahu81 ambujsahu81 deleted the bugfix/update-isPublicRepo branch March 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use meta tags in isRepoPublic
2 participants